WweiL commented on PR #40887: URL: https://github.com/apache/spark/pull/40887#issuecomment-1520622334
@amaliujia @HyukjinKwon I also changed `ProtoToParsedPlanTestSuite` a little to remove the memory addresses, before the change the test for streaming table only would fail with: ``` - streaming_table_API_with_options *** FAILED *** (8 milliseconds) [info] Expected and actual plans do not match: [info] [info] === Expected Plan === [info] SubqueryAlias primary.tempdb.myStreamingTable [info] +- StreamingRelationV2 primary.tempdb.myStreamingTable, org.apache.spark.sql.connector.catalog.InMemoryTable@752725d9, [p1=v1, p2=v2], [id#0L], org.apache.spark.sql.connector.catalog.InMemoryCatalog@347d8e2a, tempdb.myStreamingTable [info] [info] [info] === Actual Plan === [info] SubqueryAlias primary.tempdb.myStreamingTable [info] +- StreamingRelationV2 primary.tempdb.myStreamingTable, org.apache.spark.sql.connector.catalog.InMemoryTable@a88a5db, [p1=v1, p2=v2], [id#0L], org.apache.spark.sql.connector.catalog.InMemoryCatalog@2c6b362e, tempdb.myStreamingTable ``` Because the memory address is different every time it runs. I removed these in the test suite. And verified that memory addresses doesn't exist in existing explain files: ``` wei.liu:~/oss-spark$ cat connector/connect/common/src/test/resources/query-tests/explain-results/* | grep @ wei.liu:~/oss-spark$ ``` PTAL, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
