pjfanning commented on code in PR #40933:
URL: https://github.com/apache/spark/pull/40933#discussion_r1177038834
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala:
##########
@@ -175,7 +187,13 @@ private[sql] class JSONOptions(
parameters.get(WRITE_NON_ASCII_CHARACTER_AS_CODEPOINT).map(_.toBoolean).getOrElse(false)
/** Build a Jackson [[JsonFactory]] using JSON options. */
- def buildJsonFactory(): JsonFactory = {
Review Comment:
this is a public API change - which you can't do under semver rules - can
you not just access the local vars instead of changing the function signature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
