itholic commented on code in PR #40939:
URL: https://github.com/apache/spark/pull/40939#discussion_r1176535987
##########
python/pyspark/errors/error_classes.py:
##########
@@ -224,6 +224,11 @@
"Argument `<arg_name>` should be a Column, int or str, got <arg_type>."
]
},
+ "NOT_COLUMN_OR_LIST_OR_STR" : {
Review Comment:
Yes, we can either merge them into single error class as you mentioned, or
create a representative main error class and add related type errors as
sub-error classes under main error class what we do in JVM side. Each way has
its pros and cons, so we plan to proceed with the initial migration in the
current form first, and then gather opinions from ppl through decision docs or
something before making changes all at once.
I already created SPARK-43020 for address this issue, so let me do the
refactoring once the basic migration is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
