rangadi commented on code in PR #40892:
URL: https://github.com/apache/spark/pull/40892#discussion_r1177220790
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/streaming/StreamingQuery.scala:
##########
@@ -163,14 +163,14 @@ class RemoteStreamingQuery(
override def recentProgress: Array[StreamingQueryProgress] = {
executeQueryCmd(_.setRecentProgress(true)).getRecentProgress.getRecentProgressJsonList.asScala
- .map(json => new StreamingQueryProgress(json))
+ .map(StreamingQueryProgress.fromJson)
.toArray
}
override def lastProgress: StreamingQueryProgress = {
executeQueryCmd(
_.setLastProgress(true)).getRecentProgress.getRecentProgressJsonList.asScala.headOption
- .map(json => new StreamingQueryProgress(json))
+ .map(StreamingQueryProgress.fromJson)
Review Comment:
This is a good idea (at least for now). So essentially we don't need to add
many protobuf message to match :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
