CavemanIV commented on code in PR #40921:
URL: https://github.com/apache/spark/pull/40921#discussion_r1177634205
##########
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala:
##########
@@ -1139,7 +1139,12 @@ final class ShuffleBlockFetcherIterator(
case shuffleBlockChunk: ShuffleBlockChunkId =>
// TODO SPARK-36284 Add shuffle checksum support for push-based shuffle
val diagnosisResponse = s"BlockChunk $shuffleBlockChunk is corrupted
but corruption " +
- s"diagnosis is skipped due to lack of shuffle checksum support for
push-based shuffle."
+ "diagnosis is skipped due to lack of shuffle checksum support for
push-based shuffle."
+ logWarning(diagnosisResponse)
+ diagnosisResponse
+ case shuffleBlockBatch: ShuffleBlockBatchId =>
Review Comment:
I didn't find one in JIRA, seems since original implementation SPARK-36206
only checks normal ShuffleBlockId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
