WeichenXu123 commented on code in PR #40724:
URL: https://github.com/apache/spark/pull/40724#discussion_r1178603320
##########
python/pyspark/ml/torch/tests/test_distributor.py:
##########
@@ -431,7 +431,7 @@ def test_dist_training_succeeds(self) -> None:
)
self.assertEqual(
expected,
-
dist._run_distributed_training(dist._run_training_on_pytorch_file, "..."),
+
dist._run_distributed_training(dist._run_training_on_pytorch_file, "...", None),
Review Comment:
`_run_distributed_training` is an internal interface.
For internal interface, I prefer to set less default argument to prevent
careless code error (e.g. unaware of default argument being set)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
