mridulm commented on code in PR #40911:
URL: https://github.com/apache/spark/pull/40911#discussion_r1180533930
##########
core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala:
##########
@@ -934,6 +939,12 @@ private[spark] object JsonProtocolSuite extends Assertions
{
assert(newValue === expectedValue)
}
+ private def testException(exception: Exception): Unit = {
+ val newException = JsonProtocol.exceptionFromJson(
+ toJsonString(JsonProtocol.exceptionToJson(exception, _)))
+ assertEquals(exception, newException)
+ }
Review Comment:
Thinking more, since we are adding this util method - we can remove
`testStackTrace` method and delete to this as well. What we are trying to make
sure is the exception deserializes to the same - for both the message and stack
trace elements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
