hvanhovell commented on code in PR #41005:
URL: https://github.com/apache/spark/pull/41005#discussion_r1181843398
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectStreamHandler.scala:
##########
@@ -47,18 +47,29 @@ class SparkConnectStreamHandler(responseObserver:
StreamObserver[ExecutePlanResp
extends Logging {
def handle(v: ExecutePlanRequest): Unit =
SparkConnectArtifactManager.withArtifactClassLoader {
- val session =
- SparkConnectService
- .getOrCreateIsolatedSession(v.getUserContext.getUserId, v.getSessionId)
- .session
+ val sessionHolder = SparkConnectService
+ .getOrCreateIsolatedSession(v.getUserContext.getUserId, v.getSessionId)
+ val session = sessionHolder.session
+
session.withActive {
+ val debugString = try {
+ Utils.redact(
+ session.sessionState.conf.stringRedactionPattern,
+ ProtoUtils.abbreviate(v).toString)
+ } catch {
+ case e: Throwable =>
Review Comment:
Catch NonFatal please? I know the old code did the same, but swallowing
errors is typically bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
