MaxGekk commented on code in PR #40955:
URL: https://github.com/apache/spark/pull/40955#discussion_r1182106079
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1009,6 +1009,11 @@
"<value>."
]
},
+ "REGEX_GROUP_INDEX_EXCEED_REGEX_GROUP_COUNT" : {
+ "message" : [
+ "Regex group count is <groupCount>, but the specified group index is
<groupIndex>."
Review Comment:
Not obvious the valid range for `groupIndex`. Could you write the message in
the format:
```
expects ..., but got ...
```
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1009,6 +1009,11 @@
"<value>."
]
},
+ "REGEX_GROUP_INDEX_EXCEED_REGEX_GROUP_COUNT" : {
Review Comment:
Could you make it shorter, please. I think it is enough to just name the
invalid parameter. For instance, `REGEX_GROUP_INDEX`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
