HyukjinKwon commented on code in PR #41014:
URL: https://github.com/apache/spark/pull/41014#discussion_r1182408715
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -129,18 +129,18 @@ class SparkConnectService(debug: Boolean)
{
case se: SparkException if isPythonExecutionException(se) =>
- logError(s"Error during: $opType", se)
+ logError(s"Error during: $opType. UserId: $userId. SessionId:
$sessionId.", se)
observer.onError(
StatusProto.toStatusRuntimeException(
buildStatusFromThrowable(se.getCause, stackTraceEnabled)))
case e: Throwable if e.isInstanceOf[SparkThrowable] || NonFatal.apply(e)
=>
- logError(s"Error during: $opType", e)
+ logError(s"Error during: $opType. UserId: $userId. SessionId:
$sessionId.", e)
observer.onError(
StatusProto.toStatusRuntimeException(buildStatusFromThrowable(e,
stackTraceEnabled)))
case e: Throwable =>
- logError(s"Error during: $opType", e)
+ logError(s"Error during: $opType. UserId: $userId. SessionId:
$sessionId.", e)
Review Comment:
We might even have to add a wrapper of `longError`, etc. that always shows
the user id and session id. but could be done separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
