amaliujia commented on code in PR #41005:
URL: https://github.com/apache/spark/pull/41005#discussion_r1182785252
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/SparkConnectClient.scala:
##########
@@ -184,6 +184,16 @@ private[sql] class SparkConnectClient(
analyze(request)
}
+ private[sql] def interruptAll(): proto.InterruptResponse = {
+ val builder = proto.InterruptRequest.newBuilder()
Review Comment:
Unless before client is blocked by long pause GC before calling the gRPC
stub to send out the request, otherwise I think the command should be sent
without ab issue.
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/connect/client/SparkConnectClient.scala:
##########
@@ -184,6 +184,16 @@ private[sql] class SparkConnectClient(
analyze(request)
}
+ private[sql] def interruptAll(): proto.InterruptResponse = {
+ val builder = proto.InterruptRequest.newBuilder()
Review Comment:
Unless before client is blocked by long pause GC before calling the gRPC
stub to send out the request, otherwise I think the command should be sent
without an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
