pan3793 commented on code in PR #40994:
URL: https://github.com/apache/spark/pull/40994#discussion_r1182798093
##########
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala:
##########
@@ -33,7 +33,7 @@ import org.apache.spark.internal.config.JARS
import org.apache.spark.internal.config.Tests.IS_TESTING
import org.apache.spark.internal.config.UI.UI_ENABLED
-private[spark] class KubernetesTestComponents(defaultClient:
DefaultKubernetesClient) {
+private[spark] class KubernetesTestComponents(val kubernetesClient:
KubernetesClient) {
Review Comment:
Since there is no way to set `namespace` globally for the client in the new
API, we can merge the `defaultClient` and `kubernetesClient`, the `val ` is
reserved for `kubernetesClient` to minimize the change.
Before
```
class KubernetesTestComponents(defaultClient: DefaultKubernetesClient) {
val kubernetesClient = defaultClient.inNamespace(namespace)
...
}
```
After
```
class KubernetesTestComponents(val kubernetesClient: KubernetesClient) {
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
