NarekDW commented on code in PR #41018:
URL: https://github.com/apache/spark/pull/41018#discussion_r1182805619
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala:
##########
@@ -497,21 +497,20 @@ object CatalogTable {
def readLargeTableProp(props: Map[String, String], key: String):
Option[String] = {
props.get(key).orElse {
- if (props.filterKeys(_.startsWith(key)).isEmpty) {
- None
- } else {
- val numParts = props.get(s"$key.numParts")
- if (numParts.isEmpty) {
- throw
QueryCompilationErrors.cannotReadCorruptedTablePropertyError(key)
- } else {
- val parts = (0 until numParts.get.toInt).map { index =>
- props.getOrElse(s"$key.part.$index", {
- throw
QueryCompilationErrors.cannotReadCorruptedTablePropertyError(
- key, s"Missing part $index, $numParts parts are expected.")
Review Comment:
numParts is Option here, instead of printing Some(value) it is better to
keep just value in error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
