Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/6323#issuecomment-104377936
Yep, looks like both `launchTasks()` and `makeOffers()` can be private. In
general, I prefer to minimize the visibility of fields / methods as much as
possible, so let's make these private.
My PR made a similar change to `CoarseGrainedExecutorBackend`. Over there,
I added a comment to explain that the shared serializer code would need to be
revisited if we ever switched to a parallel / non-thread-safe RPC endpoint for
the actor:
https://github.com/apache/spark/pull/5606/files#diff-79391110e9f26657e415aa169a004998R51.
It would be good to make a similar comment here so that we don't forget to
update this if `DriverEndpoint` is ever parallelized.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
