hiboyang commented on code in PR #41036: URL: https://github.com/apache/spark/pull/41036#discussion_r1184476110
########## connector/connect/client/go/README.md: ########## @@ -0,0 +1,92 @@ +## Summary Review Comment: For Go, normally people put the Go code in GitHub repo, and reference that repo as a Go library (package). For example, following code references to `github.com/apache/arrow/go/v12/arrow/ipc` library which is in repo `https://github.com/apache/arrow`: ``` import "github.com/apache/arrow/go/v12/arrow/ipc" func foo() { arrowReader, err := ipc.NewReader(...) } ``` ########## connector/connect/client/go/README.md: ########## @@ -0,0 +1,92 @@ +## Summary Review Comment: Add Quick Start guide, explaining how to start a Go Spark Connect application. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
