ueshin commented on code in PR #41041:
URL: https://github.com/apache/spark/pull/41041#discussion_r1184531070
##########
python/pyspark/sql/pandas/serializers.py:
##########
@@ -226,9 +225,6 @@ def create_array(s, t):
s = _check_series_convert_timestamps_internal(s,
self._timezone)
elif t is not None and pa.types.is_map(t):
s = _convert_dict_to_map_items(s)
- elif is_categorical_dtype(s.dtype):
- # Note: This can be removed once minimum pyarrow version is >=
0.16.1
- s = s.astype(s.dtypes.categories.dtype)
Review Comment:
so we can't remove it if `t is None`. or we need to support `dictionary`
type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
