HyukjinKwon commented on code in PR #40954: URL: https://github.com/apache/spark/pull/40954#discussion_r1184633342
########## python/pyspark/pythonenv/pip_req_parser.py: ########## @@ -0,0 +1,191 @@ +# -*- coding: utf-8 -*- Review Comment: I think we should just rather add another argument, or check if it is a path ending with `.txt` (or check if `requirements.txt`), and let the `pip` decide how to address instead of investing the wheel of how to address pip requirement specification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
