Yikun commented on code in PR #36:
URL: https://github.com/apache/spark-docker/pull/36#discussion_r1184669388


##########
3.4.0/scala2.12-java11-ubuntu/Dockerfile:
##########
@@ -64,6 +65,9 @@ RUN set -ex; \
     mv examples /opt/spark/; \
     mv kubernetes/tests /opt/spark/; \
     mv data /opt/spark/; \
+    mv python/pyspark /opt/spark/python/pyspark/; \
+    mv python/lib /opt/spark/python/lib/; \
+    mv R /opt/spark/; \

Review Comment:
   > download/extract spark (maybe keeping python and R files too? they seem 
relatively small compared to the rest)
   
   This the key change:
   
   ```
   2.0M ./lib
   11M  ./pyspark
   5.6M ./R
   ```
   
   Compare to complete docker image size (500-600MB), I think it can be 
accepted, otherwise we have to download/extract/move these step into Pyspark/R.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to