maytasm commented on PR #41011: URL: https://github.com/apache/spark/pull/41011#issuecomment-1535659557
@srowen @dongjoon-hyun I don't have strong opinion either way too. However, upon thinking about it more, I am leaning toward minimal CSS change without upgrading DataTables library for the following reason: - DataTables version upgraded to 1.13.2 is only in master branch and has not been part of any release (i.e. 3.3, 3.4) yet. Making it risky - I am not familiar with DataTables library and have no idea about the changes between the current version and 1.13.2 - The CSS change is very simple, easy to understand, and has a very minimal surface area. I will put up a PR for the CSS change but will leave this PR open for a bit longer in case anyone feel strongly for upgrading DataTables to 1.13.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
