ulysses-you commented on code in PR #40390:
URL: https://github.com/apache/spark/pull/40390#discussion_r1186665749
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/RemoveRedundantSortsSuite.scala:
##########
@@ -124,6 +124,7 @@ abstract class RemoveRedundantSortsSuiteBase
test("cached sorted data doesn't need to be re-sorted") {
withSQLConf(SQLConf.REMOVE_REDUNDANT_SORTS_ENABLED.key -> "true") {
val df = spark.range(1000).select($"id" as
"key").sort($"key".desc).cache()
+ df.collect()
Review Comment:
We propagate output partitioning and ordering when the inside AQE is
`isFinalPlan`, so we should materialzed it first. For these tests, it's equal
to add `resorted.collect()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
