mridulm commented on code in PR #40690:
URL: https://github.com/apache/spark/pull/40690#discussion_r1186666232
##########
core/src/main/scala/org/apache/spark/MapOutputTracker.scala:
##########
@@ -157,22 +164,32 @@ private class ShuffleStatus(
invalidateSerializedMapOutputStatusCache()
}
mapStatuses(mapIndex) = status
+ mapIdToMapIndex(status.mapId) = mapIndex
+ }
+
+ /**
+ * Get the map output that corresponding to a given mapId.
+ */
+ def getMapStatus(mapId: Long): Option[MapStatus] = withReadLock {
+ mapIdToMapIndex.get(mapId).map(mapStatuses(_))
}
/**
* Update the map output location (e.g. during migration).
*/
def updateMapOutput(mapId: Long, bmAddress: BlockManagerId): Unit =
withWriteLock {
try {
- val mapStatusOpt = mapStatuses.find(x => x != null && x.mapId == mapId)
+ val mapIndex = mapIdToMapIndex.get(mapId)
+ val mapStatusOpt = Option(mapIndex.map(mapStatuses(_)).getOrElse(null))
Review Comment:
super nit:
```suggestion
val mapStatusOpt = mapIndex.map(mapStatuses(_)).flatMap(Option(_))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
