justaparth opened a new pull request, #41075:
URL: https://github.com/apache/spark/pull/41075
Adds a new option, enums.as.ints which allows deserializing enums as int
values. Symmetrically, we modify the serialization logic as well to allow
reading back structs where integer values are used for enums.
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
When deserializing protobuf enum fields, the spark-protobuf library will
deserialize them as string values based on the enum name in the proto. E.g.
```
message Person {
enum Job {
NOTHING = 0;
ENGINEER = 1;
DOCTOR = 2;
}
Job job = 1;
}
```
And we have a message like
```
Job(job=ENGINEER)
```
Then the deserialized value will be:
```
{"job": "ENGINEER"}
```
However it can be useful to deserialize the enum integer value rather than
the name, namely:
```
{"job": 1}
```
This commit adds that functionality to spark protobuf via an option,
"enums.as.ints". In addition, it also allows serializing such fields back into
protobuf via `to_protobuf`.
Examples in other libraries:
- protobuf-java-util JsonFormat:
https://javadoc.io/doc/com.google.protobuf/protobuf-java-util/3.10.0/com/google/protobuf/util/JsonFormat.Printer.html#printingEnumsAsInts--
- golang/protobuf jsonpb marshaler
https://pkg.go.dev/github.com/golang/protobuf/jsonpb#Marshaler
### Why are the changes needed?
Adds new functionality that exists in other libraries.
### Does this PR introduce _any_ user-facing change?
Yes, adds a new option to from_protobuf.
### How was this patch tested?
Added unit tests confirming this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
