cloud-fan commented on code in PR #40390:
URL: https://github.com/apache/spark/pull/40390#discussion_r1186986198
##########
sql/core/src/test/scala/org/apache/spark/sql/sources/DisableUnnecessaryBucketedScanSuite.scala:
##########
@@ -241,7 +241,8 @@ abstract class DisableUnnecessaryBucketedScanSuite
test("SPARK-33075: not disable bucketed table scan for cached query") {
withTable("t1") {
- withSQLConf(SQLConf.AUTO_BUCKETED_SCAN_ENABLED.key -> "true") {
+ withSQLConf(SQLConf.AUTO_BUCKETED_SCAN_ENABLED.key -> "true",
+ SQLConf.CAN_CHANGE_CACHED_PLAN_OUTPUT_PARTITIONING.key -> "false") {
Review Comment:
I think this does expose an issue. It means bucketed table scan inside table
cache is always useless because of `DisableUnnecessaryBucketedScan`. Shall we
update `DisableUnnecessaryBucketedScan` to take table cache into account?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
