NarekDW commented on code in PR #41018:
URL: https://github.com/apache/spark/pull/41018#discussion_r1187079983
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -1033,10 +1033,19 @@ private[sql] object QueryCompilationErrors extends
QueryErrorsBase {
messageParameters = Map("colName" -> colName, "dataType" ->
dataType.toString))
}
- def cannotReadCorruptedTablePropertyError(key: String, details: String =
""): Throwable = {
+ def insufficientTablePropertyError(key: String): Throwable = {
new AnalysisException(
- errorClass = "_LEGACY_ERROR_TEMP_1091",
- messageParameters = Map("key" -> key, "details" -> details))
+ errorClass = "INSUFFICIENT_TABLE_PROPERTY.MISSING_KEY",
+ messageParameters = Map("key" -> toSQLId(key)))
Review Comment:
Not sure regarding `toSQLValue()` it expects a value of some specific data
type...
What do you think about `toSQLConf`? It will wrap property with quotes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]