dongjoon-hyun commented on code in PR #41094:
URL: https://github.com/apache/spark/pull/41094#discussion_r1187977974


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BinaryComparisonSimplificationSuite.scala:
##########
@@ -228,4 +228,31 @@ class BinaryComparisonSimplificationSuite extends PlanTest 
{
 
     checkCondition(nullableRelation, $"a" <=> nullLit, $"a".isNull)
   }
+
+  test("IN subquery nullability") {
+    // Should not optimize, since the IN subquery is nullable
+    {

Review Comment:
   Let's avoid these verbose redundant `{}` copy&paste patterns.
   
   You can use `Seq(...).foreach` patterns.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to