dongjoon-hyun commented on code in PR #41082:
URL: https://github.com/apache/spark/pull/41082#discussion_r1187982520
##########
core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMonitor.scala:
##########
@@ -550,7 +550,7 @@ private[spark] class ExecutorMonitor(
// The set of shuffles for which shuffle data is held by the executor.
// This should only be used in the event thread.
- private val shuffleIds = if (shuffleTrackingEnabled) new
mutable.HashSet[Int]() else null
+ private val shuffleIds = new mutable.HashSet[Int]()
Review Comment:
Please revert this part because `if (shuffleIds != null &&
shuffleIds.nonEmpty)` is totally fine.
For this kind of PR, we need to minimize as much as possible in order to
backport easily, @warrenzhu25 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
