LuciferYang commented on code in PR #40654:
URL: https://github.com/apache/spark/pull/40654#discussion_r1188392290
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -1567,6 +1613,19 @@ class SparkConnectPlanner(val session: SparkSession) {
val expr = transformExpression(fun.getArguments(0))
Some(transformUnregisteredUDF(MLFunctions.arrayToVectorUdf, Seq(expr)))
+ // Protobuf-specific functions
+ case "from_protobuf" if Seq(2, 3, 4).contains(fun.getArgumentsCount) =>
+ val children =
fun.getArgumentsList.asScala.toSeq.map(transformExpression)
+ val (messageClassName, descFilePathOpt, options) =
+ extractArgsOfProtobufFunction("from_protobuf",
fun.getArgumentsCount, children)
+ Some(ProtobufDataToCatalyst(children.head, messageClassName,
descFilePathOpt, options))
Review Comment:
In my impression, @hvanhovell mentioned that the code in
`transformUnregisteredFunction` will be uniformly processed to reuse
`FunctionRegistry` in the future. Maybe we can wait for a unified solution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
