cloud-fan commented on code in PR #41088:
URL: https://github.com/apache/spark/pull/41088#discussion_r1188575493


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala:
##########
@@ -543,7 +561,7 @@ case class FileSourceScanExec(
         dataSchema = relation.dataSchema,
         partitionSchema = relation.partitionSchema,
         requiredSchema = requiredSchema,
-        filters = pushedDownFilters,
+        filters = dynamicallyPushedDownFilters,

Review Comment:
   One implicit change is, now we will trigger subquery execution when getting 
the rdd of the file scan node. This worries me a little bit. Can we trigger 
subquery execution in the AQE framework? e.g. before executing a query stage, 
transform the scan node and update its `dataFilters` to replace evaluated 
scalar subqueries with literals.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to