eejbyfeldt commented on code in PR #40808:
URL: https://github.com/apache/spark/pull/40808#discussion_r1188755749


##########
core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala:
##########
@@ -51,6 +51,7 @@ import org.apache.spark.util.Utils
 private[spark] class NettyBlockTransferService(
     conf: SparkConf,
     securityManager: SecurityManager,
+    serializerManager: SerializerManager,

Review Comment:
   The reason for using the `serializerManager` is that we get a configured 
serializer that are aware of custom jars. It being configured here 
https://github.com/apache/spark/blob/3cdbc176337bdb0dbe11a120b0416b4f9014d8d9/core/src/main/scala/org/apache/spark/executor/Executor.scala#L168-L172
 so we are just constructing a `JavaSerializer` internally we need to expose 
some method so we can configure the classloader that get used by it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to