srowen commented on code in PR #40808:
URL: https://github.com/apache/spark/pull/40808#discussion_r1188785599
##########
core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala:
##########
@@ -51,6 +51,7 @@ import org.apache.spark.util.Utils
private[spark] class NettyBlockTransferService(
conf: SparkConf,
securityManager: SecurityManager,
+ serializerManager: SerializerManager,
Review Comment:
That config comes through conf right? I am just wondering what the
difference is if you still make the JavaSerializer and serializer manager
inside the class rather than make the caller do it now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
