LuciferYang commented on code in PR #41036: URL: https://github.com/apache/spark/pull/41036#discussion_r1189391849
########## connector/connect/client/go/go.mod: ########## @@ -0,0 +1,53 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +module github.com/apache/spark/connector/connect/client/go/v_3_4 + +go 1.19 Review Comment: We generally just consider the LTS version for Java, Spark supports three LTS Java versions(8/11/17 and 17 is the latest LTS currently) and always build and tests using the latest minor version of each LTS, so I think Spark uses the latest version of Java. However, I'm not familiar with the version mechanism of the Go language so far, so I can't provide any better suggestions for choosing the test version at the moment. @hiboyang So can you provide more other background information? For example, which version are the mainstream Go project communities more inclined to support now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
