chaoqin-li1123 commented on code in PR #41099:
URL: https://github.com/apache/spark/pull/41099#discussion_r1190274173
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -150,8 +162,27 @@ class RocksDB(
metadata.numKeys
}
numKeysOnWritingVersion = numKeys
- numKeysOnLoadedVersion = numKeys
-
+ // Replay change log from the last snapshot to the loaded version.
+ // This will be noop if changelog checkpointing is disabled.
+ for (v <- latestSnapshotVersion + 1 to version) {
Review Comment:
Refactored.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1940,6 +1940,15 @@ object SQLConf {
// 5 is the default table format version for RocksDB 6.20.3.
.createWithDefault(5)
+ val STATE_STORE_ROCKSDB_CHANGE_CHECKPOINTING_ENABLED =
+
buildConf("spark.sql.streaming.stateStore.rocksdb.enableChangelogCheckpointing")
Review Comment:
Renamed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
