Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/759#discussion_r12601376
  
    --- Diff: 
core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala ---
    @@ -377,4 +411,12 @@ class SparkListenerSuite extends FunSuite with 
LocalSparkContext with ShouldMatc
           startedGettingResultTasks += taskGettingResult.taskInfo.index
         }
       }
    +
    +  /**
    +   * A simple listener that throws an exception on job end.
    +   */
    +  private class BadListener extends SparkListener {
    +    override def onJobEnd(jobEnd: SparkListenerJobEnd) = { 1 / 0 }
    --- End diff --
    
    I'd recommend just throwing some exception instead.
    
    (Not the case with Scala apparently, but I've seen Java compilers that 
issue a compile-time error when you do that.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to