ueshin commented on code in PR #41148:
URL: https://github.com/apache/spark/pull/41148#discussion_r1191805164
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -125,7 +125,7 @@ class SparkConnectService(debug: Boolean)
SparkConnectService
.getOrCreateIsolatedSession(userId, sessionId)
.session
- val stackTraceEnabled =
session.conf.get(PYSPARK_JVM_STACKTRACE_ENABLED.key, "true").toBoolean
+ val stackTraceEnabled = session.conf.get(PYSPARK_JVM_STACKTRACE_ENABLED)
Review Comment:
That's a good point.
The original PR is for Spark Connect Python client and it was supposed to be
disabled by default if it's not testing mode:
https://github.com/apache/spark/blob/939c5f507b1d3225d9575ae39ab494df092c6c9e/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala#L2780-L2789
For Scala client, I think it's TBD?
https://github.com/apache/spark/pull/40575#issuecomment-1512439357 cc
@allisonwang-db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
