LuciferYang commented on PR #41122:
URL: https://github.com/apache/spark/pull/41122#issuecomment-1545057975

   When I tried this upgrade, I found that the result of 
'StateStoreBasicOperationsBenchmark' was unexpected. For check if it was a new 
version(8.1.1.1) issue, I also ran the 'StateStoreBasicOperationsBenchmark' on 
the master branch(with 8.0.0), and there were significant differences between 
the test data and the previous records and 'StateStoreBasicOperationsBenchmark' 
also run timeout(more than 6hours, It should have been completed in 3 hours 
before):
   
   https://github.com/LuciferYang/spark/actions/runs/4949396450/jobs/8856766625
   
   ``
   [success] Total time: 791 s (13:11), completed May 11, 2023 7:33:07 PM
   23/05/11 19:33:12 WARN NativeCodeLoader: Unable to load native-hadoop 
library for your platform... using builtin-java classes where applicable
   Running 
org.apache.spark.sql.execution.benchmark.StateStoreBasicOperationsBenchmark:
   23/05/11 19:33:15 WARN SparkContext: The JAR 
file:/home/runner/work/spark/spark/core/target/scala-2.12/spark-core_2.12-3.5.0-SNAPSHOT-tests.jar
 at spark://localhost:44659/jars/spark-core_2.12-3.5.0-SNAPSHOT-tests.jar has 
been added already. Overwriting of added jar is not supported in the current 
version.
   Running benchmark: putting 10000 rows (10000 rows to overwrite - rate 100)
     Running case: In-memory
     Stopped after 10000 iterations, 82351 ms
     Running case: RocksDB (trackTotalNumberOfRows: true)
     Stopped after 10000 iterations, 599839 ms
     Running case: RocksDB (trackTotalNumberOfRows: false)
     Stopped after 10000 iterations, 210482 ms
   
   OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1037-azure
   Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
   putting 10000 rows (10000 rows to overwrite - rate 100):  Best Time(ms)   
Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
   
---------------------------------------------------------------------------------------------------------------------------------------
   In-memory                                                            7       
       8           1          1.4         739.9       1.0X
   RocksDB (trackTotalNumberOfRows: true)                              58       
      60           1          0.2        5828.2       0.1X
   RocksDB (trackTotalNumberOfRows: false)                             20       
      21           0          0.5        2033.4       0.4X
   
   OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1037-azure
   Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
   putting 10000 rows (7500 rows to overwrite - rate 75):  Best Time(ms)   Avg 
Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
   
-------------------------------------------------------------------------------------------------------------------------------------
   In-memory                                                          8         
     9           1          1.3         772.9       1.0X
   RocksDB (trackTotalNumberOfRows: true)                            56         
    58           1          0.2        5567.7       0.1X
   RocksDB (trackTotalNumberOfRows: false)                           21         
    23           4          0.5        2126.2       0.4X
   
   OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1037-azure
   Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
   putting 10000 rows (5000 rows to overwrite - rate 50):  Best Time(ms)   Avg 
Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
   
-------------------------------------------------------------------------------------------------------------------------------------
   In-memory                                                          8         
     9           1          1.3         760.7       1.0X
   RocksDB (trackTotalNumberOfRows: true)                            51         
    53           1          0.2        5089.3       0.1X
   RocksDB (trackTotalNumberOfRows: false)                           21         
    22           1          0.5        2133.7       0.4X
   
   
   OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1037-azure
   Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
   putting 10000 rows (2500 rows to overwrite - rate 25):  Best Time(ms)   Avg 
Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
   
-------------------------------------------------------------------------------------------------------------------------------------
   In-memory                                                          7         
     8           1          1.3         747.6       1.0X
   RocksDB (trackTotalNumberOfRows: true)                            46         
    47           1          0.2        4603.3       0.2X
   RocksDB (trackTotalNumberOfRows: false)                           21         
    22           1          0.5        2141.8       0.3X
   
   
   OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1037-azure
   Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
   putting 10000 rows (1000 rows to overwrite - rate 10):  Best Time(ms)   Avg 
Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
   
-------------------------------------------------------------------------------------------------------------------------------------
   In-memory                                                          7         
     8           1          1.4         732.3       1.0X
   RocksDB (trackTotalNumberOfRows: true)                            43         
    44           1          0.2        4283.7       0.2X
   RocksDB (trackTotalNumberOfRows: false)                           21         
    22           1          0.5        2132.0       0.3X
   
   
   OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1037-azure
   Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
   putting 10000 rows (500 rows to overwrite - rate 5):  Best Time(ms)   Avg 
Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
   
-----------------------------------------------------------------------------------------------------------------------------------
   In-memory                                                        7           
   8           1          1.4         732.3       1.0X
   RocksDB (trackTotalNumberOfRows: true)                          42           
  43           1          0.2        4169.4       0.2X
   RocksDB (trackTotalNumberOfRows: false)                         21           
  22           1          0.5        2124.4       0.3X
   
   
   OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1037-azure
   Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
   putting 10000 rows (0 rows to overwrite - rate 0):  Best Time(ms)   Avg 
Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
   
---------------------------------------------------------------------------------------------------------------------------------
   In-memory                                                      7             
 8           1          1.4         727.9       1.0X
   RocksDB (trackTotalNumberOfRows: true)                        40             
42           1          0.2        4038.6       0.2X
   RocksDB (trackTotalNumberOfRows: false)                       21             
22           1          0.5        2129.9       0.3X
   
   .......
   
   OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1037-azure
   Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
   evicting 1000 rows (maxTimestampToEvictInMillis: 999) from 10000 rows:  Best 
Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
   
-----------------------------------------------------------------------------------------------------------------------------------------------------
   In-memory                                                                    
      5              5           0          2.2         458.3       1.0X
   RocksDB (trackTotalNumberOfRows: true)                                       
      9              9           0          1.1         871.2       0.5X
   RocksDB (trackTotalNumberOfRows: false)                                      
      5              6           0          1.9         518.3       0.9X
   
   Running benchmark: evicting 500 rows (maxTimestampToEvictInMillis: 499) from 
10000 rows
     Running case: In-memory
     Stopped after 10000 iterations, 50617 ms
     Running case: RocksDB (trackTotalNumberOfRows: true)
   Error: The operation was canceled.
   ```
   
   I will try to investigate this issue, cc @dongjoon-hyun @HeartSaVioR FYI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to