chaoqin-li1123 commented on code in PR #41099:
URL: https://github.com/apache/spark/pull/41099#discussion_r1193339733
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -369,6 +458,9 @@ class RocksDB(
flushOptions.close()
dbOptions.close()
dbLogger.close()
+ synchronized {
+ latestCheckpoint.foreach(_.close())
Review Comment:
I think you are right, the checkpoint don't contain any resource other than
the local temp dir which is going to be closed by the below statement anyway.
But to be future proof(we may add other resource to it), I prefer to keep the
free the resources explicitly here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
