gengliangwang commented on PR #41007: URL: https://github.com/apache/spark/pull/41007#issuecomment-1548631061
@srielau I am rethinking the requirement after reading the related docs (especially [the doc from snowflake](https://docs.snowflake.com/en/sql-reference/identifier-literal)) So how important it is to support all kinds of expressions(e.g string concats) within the `IDENTIFIER()` clause? It would be much easier if we limit the requirement only accepts the following: * quoted identifier * session variable So, instead of ``` identifierReference : IDENTIFIER_KW LEFT_PAREN expression RIGHT_PAREN | multipartIdentifier ; ``` We can make it ``` identifierReference : IDENTIFIER_KW LEFT_PAREN '\'' multipartIdentifier '\'' RIGHT_PAREN | IDENTIFIER_KW LEFT_PAREN '"' multipartIdentifier '"' RIGHT_PAREN | multipartIdentifier ; ``` And this requires much less changes in the parser and analyzer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
