mridulm commented on code in PR #41105:
URL: https://github.com/apache/spark/pull/41105#discussion_r1194654288
##########
core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala:
##########
@@ -48,11 +48,28 @@ private[history] class ApplicationCache(
val retainedApplications: Int,
val clock: Clock) extends Logging {
+ /**
+ * Keep track of SparkUIs in [[ApplicationCache#appCache]] and SparkUIs
removed from
+ * [[ApplicationCache#appCache]] but not detached yet.
+ */
+ private val loadedApps = new ConcurrentHashMap[CacheKey, CountDownLatch]()
+
private val appLoader = new CacheLoader[CacheKey, CacheEntry] {
/** the cache key doesn't match a cached entry, or the entry is
out-of-date, so load it. */
override def load(key: CacheKey): CacheEntry = {
- loadApplicationEntry(key.appId, key.attemptId)
+ // Ensure old SparkUI has been detached before loading new one.
+ val removalLatch = loadedApps.get(key)
+ if (removalLatch != null) {
+ // Old SparkUI is in the middle of detaching.
+ // Waiting 10 seconds should be enough since detaching usually takes
less than 1 second.
+ if (!removalLatch.await(10, TimeUnit.SECONDS)) {
Review Comment:
To clarify, `load` is now going to wait for the `onRemoval` to complete -
and going down `detachSparkUI` call tree, there are `synchronized` blocks in
some of the subtrees.
I am unsure how contended these might be, how expensive some of those
operations are (closing the store, for example), what the potential time taken
are ... and this was the context of my query around whether 10s is
sufficient/too little/too high ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
