cloud-fan commented on code in PR #41094:
URL: https://github.com/apache/spark/pull/41094#discussion_r1195846275
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -4199,6 +4199,16 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val LEGACY_IN_SUBQUERY_NULLABILITY =
+ buildConf("spark.sql.legacy.inSubqueryNullability")
+ .internal()
+ .doc(s"When set to false, IN subquery nullability is correctly
calculated based on " +
+ s"both the left and right sides of the IN. When set to true, restores
the legacy " +
+ "behavior that does not check the right side's nullability.")
+ .version("3.5.0")
+ .booleanConf
+ .createWithDefault(false)
Review Comment:
I think the purpose of this flag is not to let users go back to the wrong
result, but just in case the newly added assertion fails. I think it's better
to mention this flag in the assert error message, than mentioning it in the
migration guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
