SandishKumarHN commented on code in PR #41192:
URL: https://github.com/apache/spark/pull/41192#discussion_r1196002786
##########
connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/functions.scala:
##########
@@ -148,8 +212,38 @@ object functions {
messageName: String,
descFilePath: String,
options: java.util.Map[String, String]): Column = {
+ val fileContent = ProtobufUtils.readDescriptorFileContent(descFilePath)
Review Comment:
Can't we change CatalystDataToProtobuf and ProtobufDataToCatalyst to accept
descFilePath or fileDescriptorSetBytes as optional parameters instead of
passing them in functions? Perhaps we could throw an error if both are not set?
This is just a thought.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
