wangyum opened a new pull request, #41195:
URL: https://github.com/apache/spark/pull/41195

   ### What changes were proposed in this pull request?
   
   This PR adds `log4j-1.2-api` and `log4j-slf4j2-impl` to classpath if active 
`hadoop-provided`.
   
   ### Why are the changes needed?
   
   To fix log issue.
   
   How to reproduce this issue:
   1. Build Spark:
      ```
      ./dev/make-distribution.sh --name default --tgz -Phive 
-Phive-thriftserver -Pyarn -Phadoop-provided
      tar -zxf spark-3.5.0-SNAPSHOT-bin-default.tgz 
      ```
   2. Remove the following jars from spark-3.5.0-SNAPSHOT-bin-default:
      ```
      jars/log4j-1.2-api-2.20.0.jar
      jars/log4j-slf4j2-impl-2.20.0.jar
      ```
   3. Add a new log4j2.properties to spark-3.5.0-SNAPSHOT-bin-default/conf:
      ```
      rootLogger.level = info
      rootLogger.appenderRef.file.ref = File
      rootLogger.appenderRef.stderr.ref = console
      
      appender.console.type = Console
      appender.console.name = console
      appender.console.target = SYSTEM_ERR
      appender.console.layout.type = PatternLayout
      appender.console.layout.pattern = %d{yy/MM/dd HH:mm:ss,SSS} %p [%t] 
%c{2}:%L : %m%n
      
      appender.file.type = RollingFile
      appender.file.name = File
      appender.file.fileName = /tmp/spark/logs/spark.log
      appender.file.filePattern = /tmp/spark/logs/spark.%d{yyyyMMdd-HH}.log
      appender.file.append = true
      appender.file.layout.type = PatternLayout
      appender.file.layout.pattern = %d{yy/MM/dd HH:mm:ss,SSS} %p [%t] %c{2}:%L 
: %m%n
      appender.file.policies.type = Policies
      appender.file.policies.time.type = TimeBasedTriggeringPolicy
      appender.file.policies.time.interval = 1
      appender.file.policies.time.modulate = true
      appender.file.policies.size.type = SizeBasedTriggeringPolicy
      appender.file.policies.size.size = 256M
      appender.file.strategy.type = DefaultRolloverStrategy
      appender.file.strategy.max = 100
      ```
   4. Start Spark thriftserver: `sbin/start-thriftserver.sh`
   
   5. The log file is empty: `cat /tmp/spark/logs/spark.log`.
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Manual test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to