dtenedor commented on code in PR #41203:
URL: https://github.com/apache/spark/pull/41203#discussion_r1196808900
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/datasketchesAggregates.scala:
##########
@@ -265,6 +288,26 @@ case class HllUnionAgg(
override protected def withNewChildrenInternal(newLeft: Expression,
newRight: Expression):
HllUnionAgg = copy(left = newLeft, right = newRight)
+ // Overrides for ExpectsInputTypes
+
+ override def checkInputDataTypes(): TypeCheckResult = {
Review Comment:
this looks mostly duplicated with L104-120 above. Can we dedup into one
place and just call the helper twice instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
