tgravescs commented on code in PR #41173:
URL: https://github.com/apache/spark/pull/41173#discussion_r1198121817
##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala:
##########
@@ -91,6 +91,9 @@ private[yarn] class YarnAllocator(
@GuardedBy("this")
private val releasedContainers = collection.mutable.HashSet[ContainerId]()
+ @GuardedBy("this")
+ private val completedContainerIds = collection.mutable.HashSet[ContainerId]()
Review Comment:
you never remove anything from this? Seems like we are adding a bunch of
extra memory pressure for very long running applications using dynamic
allocation that might have a lot of containers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
