MaxGekk commented on code in PR #41214:
URL: https://github.com/apache/spark/pull/41214#discussion_r1198595578
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala:
##########
@@ -407,8 +407,8 @@ private[sql] object QueryParsingErrors extends
QueryErrorsBase {
def computeStatisticsNotExpectedError(ctx: IdentifierContext): Throwable = {
new ParseException(
- errorClass = "_LEGACY_ERROR_TEMP_0036",
- messageParameters = Map("ctx" -> ctx.getText),
+ errorClass = "INVALID_SQL_SYNTAX",
+ messageParameters = Map("inputString" -> s"${ctx.getText} must be
${toSQLStmt("NOSCAN")}"),
Review Comment:
It would be better to do not embed error's text in source code. Could you
leave the error class as a separate one (+ assign name) or at least make it as
a sub-class of `INVALID_SQL_SYNTAX`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
