shuwang21 commented on PR #41225: URL: https://github.com/apache/spark/pull/41225#issuecomment-1555014603
> > Do you think when `spark.network.crypto.saslFallback=true` and L95 from `AuthRpcHandler.java`. > > ``` > > saslHandler = new SaslRpcHandler(conf, channel, null, secretKeyHolder); > > ``` > > > > > > > > > > > > > > > > > > > > > > > > which will set `delegate=null`. Will this cause potential NPE? > > No, with this modification, we obtain the reference to the `MergedBlockMetaReqHandler` from the `delegate (ExternalBlockHandler)` that the `AuthRpcHandler` is initialized with. The `saslHandler` instance within the `AuthRpcHandler` is specifically created for fallback to SASL, and we should not have used it to retrieve the MergedBlockMetaReqHandler. It is insignificant whether the saslHandler is initialized with a null delegate or not. I see. Make sense to me. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
