zhenlineo commented on code in PR #41284:
URL: https://github.com/apache/spark/pull/41284#discussion_r1203077171
##########
connector/connect/common/src/main/scala/org/apache/spark/sql/connect/common/DataTypeProtoConverter.scala:
##########
@@ -26,7 +26,7 @@ import org.apache.spark.util.Utils
/**
* Helper class for conversions between [[DataType]] and [[proto.DataType]].
*/
-object DataTypeProtoConverter {
+private[sql] object DataTypeProtoConverter {
Review Comment:
@grundprinzip Should the converters in common marked as public? Also see
`LiteralValueProtoConverter` and `StorageLevelProtoConverter`
Can we modify them to be package protected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
