WweiL commented on code in PR #41129:
URL: https://github.com/apache/spark/pull/41129#discussion_r1203099036
##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -216,6 +216,7 @@ message WriteStreamOperationStart {
message StreamingForeachWriter {
oneof writer {
PythonUDF python_writer = 1;
+ ScalarScalaUDF scala_writer = 2;
Review Comment:
@zhenlineo For python at least pythonVersion is needed so I think it's
better to just use PythonUDF? Then I think it's probably better to use scalaUDF
for same reason.
> Would you add more fields in the UDFs or in this StreamingForeachWriter?
I don't think so. We don't seem to update foreachWriter in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
