Fokko commented on PR #41238:
URL: https://github.com/apache/spark/pull/41238#issuecomment-1560964066
This would actually allow:
```scala
def createSerializerForLocalDateTime(inputObject: Expression): Expression
= {
StaticInvoke(
DateTimeUtils.getClass,
TimestampNTZType,
"localDateTimeToMicros",
inputObject :: Nil,
returnNullable = false)
}
```
to change to:
```scala
def createSerializerForLocalDateTime(inputObject: Expression): Expression
= {
StaticInvoke(
DateTimeUtils.getClass,
TimestampNTZType,
"anyToMicros",
inputObject :: Nil,
returnNullable = false)
}
```
This would also make some code on the Iceberg side simpler:
https://github.com/apache/iceberg/blob/8fe6248736a8a15a8dc85376c8741cbce62e6b47/spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkValueConverter.java#L78-L86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
