MaxGekk commented on code in PR #41309:
URL: https://github.com/apache/spark/pull/41309#discussion_r1205128431
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -2117,6 +2117,11 @@
"Table <tableName> does not support <operation>. Please check the
current catalog and namespace to make sure the qualified table name is
expected, and also check the catalog implementation which is configured by
\"spark.sql.catalog\"."
]
},
+ "TIME_TRAVEL" : {
+ "message" : [
+ "Time travel on: <target>"
Review Comment:
Wouldn't be more helpful for users to show some id of the target (table
name, for instance) instead of the generic string `path-based tables`? This
could help in troubleshooting the issue.
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:
##########
@@ -2977,15 +2977,15 @@ class DataSourceV2SQLSuiteV1Filter
exception = intercept[AnalysisException] {
sql("SELECT * FROM parquet.`/the/path` VERSION AS OF 1")
},
- errorClass = "_LEGACY_ERROR_TEMP_1336",
+ errorClass = "UNSUPPORTED_FEATURE.TIME_TRAVEL",
sqlState = None,
parameters = Map("target" -> "path-based tables"))
Review Comment:
Have you considered to introduce sub-classes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
