MaxGekk commented on code in PR #41279:
URL: https://github.com/apache/spark/pull/41279#discussion_r1205137320
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -5680,4 +5687,4 @@
"Failed to get block <blockId>, which is not a shuffle block"
]
}
-}
\ No newline at end of file
+}
Review Comment:
Please, revert the changes.
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowPartitionsSuite.scala:
##########
@@ -117,6 +117,17 @@ class ShowPartitionsSuite extends ShowPartitionsSuiteBase
with CommandSuiteBase
}
}
+ test("show partitions of non-partitioned table") {
+ withNamespaceAndTable("ns", "not_partitioned_table") { t =>
+ sql(s"CREATE TABLE $t (col1 int) $defaultUsing")
+ val errMsg = intercept[AnalysisException] {
+ sql(s"SHOW PARTITIONS $t")
+ }.getMessage
+
+ assert(errMsg.contains("not allowed on a table that is not partitioned"))
Review Comment:
Could you use `checkError`, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
